Log error if we attempt to cache a "bad" value#6794
Merged
labkey-adam merged 6 commits intodevelopfrom Jun 28, 2025
Merged
Conversation
labkey-adam
changed the title
labkey-matthewb
approved these changes
Jun 27, 2025
Contributor
Author
|
Existing automated tests have flagged the classes I changed and these same tests validate the changes I made. I don't see a value in manual or further automated tests here or in the companion PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We don't want cached objects holding onto
ContainerorUserobjects: https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=53058We've cleared most (maybe all?) cases, so it's time to crank up the logging to flush out any hiding stragglers. This PR also logs errors when we detect a mutable collection or array getting cached; for a long time, we've logged these as warnings.
Related Pull Requests